]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
slider: Do not notify on parent's behalf
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 12 Aug 2019 15:40:54 +0000 (17:40 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Tue, 13 Aug 2019 14:35:17 +0000 (16:35 +0200)
Instead just use the regular property setter which since commit 3d3dca4aa
already emits the signal and queues a redraw.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1500

js/ui/slider.js

index 7672cf67efd90ed4a504a2785c2dd73cfc21fa88..3e35dbcb26199ed56fdd060abc538d859afb8d68 100644 (file)
@@ -155,10 +155,8 @@ var Slider = GObject.registerClass({
             delta = -dy * SLIDER_SCROLL_STEP;
         }
 
-        this._value = Math.min(Math.max(0, this._value + delta), this._maxValue);
+        this.value = Math.min(Math.max(0, this._value + delta), this._maxValue);
 
-        this.queue_repaint();
-        this.notify('value');
         return Clutter.EVENT_STOP;
     }
 
@@ -177,10 +175,8 @@ var Slider = GObject.registerClass({
         let key = event.get_key_symbol();
         if (key == Clutter.KEY_Right || key == Clutter.KEY_Left) {
             let delta = key == Clutter.KEY_Right ? 0.1 : -0.1;
-            this._value = Math.max(0, Math.min(this._value + delta, this._maxValue));
-            this.queue_repaint();
             this.emit('drag-begin');
-            this.notify('value');
+            this.value = Math.max(0, Math.min(this._value + delta, this._maxValue));
             this.emit('drag-end');
             return Clutter.EVENT_STOP;
         }
@@ -202,9 +198,7 @@ var Slider = GObject.registerClass({
             newvalue = 1;
         else
             newvalue = (relX - handleRadius) / (width - 2 * handleRadius);
-        this._value = newvalue * this._maxValue;
-        this.queue_repaint();
-        this.notify('value');
+        this.value = newvalue * this._maxValue;
     }
 
     _getMinimumIncrement() {